[rabbit] enable quorum queues #884
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SeanMooney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
let's test it with downstream uni job that runs minor updates |
SeanMooney
force-pushed
the
quorum_queues
branch
2 times, most recently
from
f95b584 to
97de8d4
Compare
| @@ -55,19 +55,10 @@ key={{.SSLCertificateKeyFile}} | |||
| lock_path = /var/lib/nova/tmp | |||
|
|
|||
| [oslo_messaging_rabbit] | |||
| amqp_durable_queues=false | |||
There was a problem hiding this comment.
rabbit notes that durable queue are required for quorm queues
https://www.rabbitmq.com/docs/quorum-queues#feature-comparison
but the oslo messaging option is ignored if quorum queues are enabled
https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/amqp.py#L33-L37
so its more correct to not set this
There was a problem hiding this comment.
oh, good point, this wont' work w/o durable queues, and that requires separated vhosts for osp services, right?
There was a problem hiding this comment.
The last time I tested a rabbit cluster with quorum queues with my Jepsen fork, it was not possible to do w/o setting durable queues, FYI.
There was a problem hiding this comment.
so i think reading the commnet in oslo that oslo will enable durable queue if you request quorma cues and ignore the amqp_druable_queues value
this failed with
amqp.exceptions.PreconditionFailed: Exchange.declare: (406) PRECONDITION_FAILED - inequivalent arg 'durable' for exchange 'nova' in vhost '/': received 'true' but current is 'false'
and i think that was because all the other operators are using false.
ill try expclity setting ti to true but i think this just wont work without vhost
There was a problem hiding this comment.
this just wont work without vhost
yes, as other services would conflict on creating things (like exchange 'openstack') there with different persistence flags
There was a problem hiding this comment.
technically, we might want to test the altogether switch of the openstack services to that option in the downstream testproject
There was a problem hiding this comment.
Technically you should not be doing any dev downstream and we should be testing changing this everywhere upstream.
we could just make nova use a separate rabbit for this testing but in reality this is better to test manually in a local deployment then try and do it in the ci.
with that said i wont really have time to work on this so what ever way works for you.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d7f967eea0394f49b1a180bc92d12552 ✔️ openstack-meta-content-provider SUCCESS in 1h 28m 02s |
This change simplfies the oslo_messaging_rabbit config generations by enabling rabbit_quorum_queue and hardcoding heartbeat_in_pthread as false. Closes: OSPRH-9736 Related: OSPRH-10790
SeanMooney
force-pushed
the
quorum_queues
branch
from
97de8d4 to
32b083d
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3f14e91efe7f462c81a155dc27155d70 ✔️ openstack-meta-content-provider SUCCESS in 1h 27m 29s |
This change simplfies the oslo_messaging_rabbit config generations
by enabling rabbit_quorum_queue and hardcoding heartbeat_in_pthread
as false.
Closes: OSPRH-9736
Related: OSPRH-10790